Update diagram support to correspond to Kroki v0.24.1 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses https://github.com/terrastruct/d2 to render https://d2lang.com diagrams. Support was added in [email protected]. References #42.
Uses https://github.com/softwaretechnik-berlin/dbml-renderer to render https://dbml.org diagrams. Support was added in [email protected]. References #42.
Uses https://github.com/kevinpt/symbolator to render VHDL/Verilog diagrams. Support was added in [email protected]. References #42.
Uses https://github.com/pgf-tikz/pgf to render Tikz/PGF plots. Support was added in [email protected]. References #42, closes #46.
Uses https://github.com/formatc1702/WireViz to render wiring diagrams. Support was added in [email protected]. References #42.
JPEG support for these diagram types has been changed in Kroki itself as of [[email protected]](https://github.com/yuzutech/kroki/releases/tag/v0.21.0). References yuzutech/kroki#1536.
Previously the `blockdiag` related diagrams were grouped together resulting in some other diagram types having been inserted into incorrect locations, e.g. `diagramsnet`. To prevent these types of issues it's better if lexical ordering is applied everywhere.
As of [email protected][^1] the BlockDiag related tools, i.e. ActDiag, BlockDiag, NwDiag, PacketDiag, RackDiag, and SeqDiag are incorporated into the "core" container image. Therefore the separate container is no longer necessary. [^1]: https://github.com/yuzutech/kroki/releases/tag/v0.22.0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #56 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 5 5
Lines 147 147
=============================================
Hits 147 147 ☔ View full report in Codecov by Sentry. |
bauglir
added a commit
that referenced
this pull request
Mar 21, 2024
This was committed (and merged) incorrectly in #56. The corresponding workflow was previously not marked as required.
bauglir
added a commit
that referenced
this pull request
Mar 21, 2024
"TikZ/PGF" was incorrectly marked as "Symbolator" in #56 as a result of copy and pasting/duplicating the line when adding TikZ/PGF support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the package up-to-date with the state of supported diagrams up to Kroki v0.24.1.
Closes #42, #46.